Fix createFromFormat to respect setTestNow for missing components #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
setTestNow()is used for testing,createFromFormat()now uses values from the test time for any date/time components not present in the format string.Previously, partial formats like
createFromFormat('m-d', '10-05')would use the real system time for the year, making tests unreliable. Now it uses the testNow year.The fix:
!and|modifiers which intentionally reset unspecified components to Unix epoch/zeroExample
Test plan
!and|reset modifiersCloses #452