Set dependency of sundials #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daklauss
force-pushed
the
Fix-dependencies
branch
from
dd32fa4 to
d147299
Compare
Member
Author
|
Seems to work for now. Maybe have to update some things to be able to use sundials >7.x idk but for now this seems to be a fix |
Contributor
|
Maybe you can relax it a bit to Other than that, do you know what broke it? Is this a |
daklauss
force-pushed
the
Fix-dependencies
branch
from
d147299 to
4c96aa9
Compare
Contributor
|
LGTM, for next time, the convention would be to pin a version. But it's not that important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set sundials to a specific version.