Skip to content

🎨 Palette: Wide hit targets & VoiceOver support for list rows#72

Open
acebytes wants to merge 1 commit intomainfrom
palette/ux-wide-hit-targets-13206190863875135799
Open

🎨 Palette: Wide hit targets & VoiceOver support for list rows#72
acebytes wants to merge 1 commit intomainfrom
palette/ux-wide-hit-targets-13206190863875135799

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 2, 2026

💡 What

Wrapped the list row contents (CategoryRow and NodeModulesRow) in a plain-styled Button and applied a rectangular content shape. Also combined the inner accessibility elements into a single group and dynamically added the .isSelected trait.

🎯 Why

Previously, only the tiny circular checkbox icon acted as the actionable hit target, forcing users to click with precise accuracy. By expanding the hit target to the entire row (including empty space), interaction becomes much more intuitive and effortless.

📸 Before/After

Before: Only the 20x20 checkbox area registered clicks. VoiceOver read out individual text fragments disjointedly without proper state context.
After: The entire horizontal width of the list item acts as a unified, clickable hit target.

♿ Accessibility

  • Added .accessibilityElement(children: .combine) so screen readers announce the row content cohesively rather than stuttering through individual text elements.
  • Conditionally applied .accessibilityAddTraits([.isSelected]) when the item is checked, giving VoiceOver users clear state feedback.

PR created automatically by Jules for task 13206190863875135799 started by @acebytes

Wrapped row contents in a plain-styled Button and added a rectangular content shape to make empty space clickable in CategoryRow and NodeModulesRow. Also combined accessibility elements and added selection traits for better VoiceOver experience.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant