Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in shell wrappers#69

Open
acebytes wants to merge 1 commit intomainfrom
sentinel-fix-shell-injection-8945491455537846702
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in shell wrappers#69
acebytes wants to merge 1 commit intomainfrom
sentinel-fix-shell-injection-8945491455537846702

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 1, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command injection vulnerabilities were present in CacheCategory.swift where dynamic user-provided input (tool) was improperly inserted into a /bin/bash -c shell execution wrapper. A similar architectural anti-pattern was fixed in CacheoutViewModel.swift for the Docker prune command.
🎯 Impact: An attacker or untrusted configuration could potentially execute arbitrary shell commands if the tool variable contained maliciously crafted shell operators.
πŸ”§ Fix: Removed /bin/bash -c dependencies and replaced them with direct execution via Process(). The tool execution now sets executableURL = URL(fileURLWithPath: "/usr/bin/env") and safely manages parameters exclusively via the arguments array (e.g., ["which", tool] and ["docker", "system", "prune", "-f"]). Standard output and error flows were also secured to either discard unused data (FileHandle.nullDevice) or properly pipe them for safe internal usage.
βœ… Verification: Execute the standard test suite. Test UI features like Docker prune handling and node_modules scanning capabilities locally on a macOS device to ensure equivalent functionality.


PR created automatically by Jules for task 8945491455537846702 started by @acebytes

- Replace string-interpolated `/bin/bash -c "which \(tool)"` with direct `Process` execution via `/usr/bin/env` in `CacheCategory.swift`
- Replace `/bin/bash -c "docker system prune -f 2>&1"` with explicit `Process` execution in `CacheoutViewModel.swift`
- Suppress output securely using `FileHandle.nullDevice` and shared `Pipe` instance.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant