Skip to content

🎨 Palette: Make list rows fully clickable#67

Open
acebytes wants to merge 1 commit intomainfrom
palette/clickable-list-rows-11764635391321077312
Open

🎨 Palette: Make list rows fully clickable#67
acebytes wants to merge 1 commit intomainfrom
palette/clickable-list-rows-11764635391321077312

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 1, 2026

💡 What
Wrapped the list rows (CategoryRow and NodeModulesRow) in full-width Buttons and applied .contentShape(Rectangle()) instead of relying on the small checkbox onTapGesture.

🎯 Why
Previously, the user had to precisely click the small checkbox icon to select a cache category or project folder. This makes selection much faster and easier for mouse/trackpad users by turning the entire row into a hit target.

📸 Before/After
(Visuals remain identical thanks to .buttonStyle(.plain), but the clickable area expands from a 20x20px circle to the full ~400x40px row).

♿ Accessibility
Combined the child elements into a single cohesive VoiceOver readout using .accessibilityElement(children: .combine). Added the .isButton trait, as well as .isSelected dynamically based on state, significantly improving screen reader navigation.


PR created automatically by Jules for task 11764635391321077312 started by @acebytes

- Wrapped CategoryRow and NodeModulesRow in Buttons.
- Applied `.contentShape(Rectangle())` for a larger hit target.
- Added accessibility element modifiers for VoiceOver.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant