Skip to content

⚡ Bolt: [performance improvement] Optimize collection processing in CacheoutViewModel #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acebytes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Optimize collection processing in CacheoutViewModel #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Sources/Cacheout/ViewModels/CacheoutViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ class CacheoutViewModel: ObservableObject {
}

var selectedSize: Int64 {
selectedResults.reduce(0) { $0 + $1.sizeBytes }
// ⚡ Bolt Optimization: Chain .lazy.filter before .reduce to prevent intermediate array allocations
scanResults.lazy.filter(\.isSelected).reduce(0) { $0 + $1.sizeBytes }
}

var formattedSelectedSize: String {
Expand All @@ -118,7 +119,10 @@ class CacheoutViewModel: ObservableObject {
}

var hasResults: Bool { !scanResults.isEmpty || !nodeModulesItems.isEmpty }
var hasSelection: Bool { !selectedResults.isEmpty || selectedNodeModulesSize > 0 }
var hasSelection: Bool {
// ⚡ Bolt Optimization: Use .contains(where:) to short-circuit evaluation instead of checking .isEmpty on an eagerly filtered array or reducing sizes
scanResults.contains(where: \.isSelected) || nodeModulesItems.contains(where: \.isSelected)
}

// MARK: - Node Modules computed properties

Expand Down
Loading