🎨 Palette: Add VoiceOver support to node_modules section header#285
🎨 Palette: Add VoiceOver support to node_modules section header#285acebytes wants to merge 1 commit into
Conversation
Added dynamic value and hint to the node_modules section header button, using `.combine` to group content for VoiceOver. Removing `.accessibilityLabel` ensures dynamically rendered children text (e.g. total size) are not overridden. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:Added dynamic value and hint to the node_modules section header button, using.combineto group content for VoiceOver.🎯 Why:Without an explicit accessibility value, VoiceOver users don't know if the section is expanded or collapsed, and mixed content is read poorly. Removing.accessibilityLabelensures dynamically rendered children text (e.g. total size) are not overridden.📸 Before/After:N/A (Non-visual accessibility change)♿ Accessibility:Improved VoiceOver experience for the node_modules section header by combining children and adding explicit state and hints.PR created automatically by Jules for task 5895877350704400929 started by @acebytes