⚡ Bolt: [performance improvement] Short-circuit evaluation and prevent intermediate array allocations#284
Conversation
…t intermediate array allocations Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced eager
.isEmptychecks on filtered collections with early-exiting.contains(where:)inhasSelection, and chained.lazy.filterbefore.reduceinselectedSize.🎯 Why: SwiftUI computed properties are evaluated very frequently during render cycles. Unnecessary intermediate array allocations (from eager filters) and full traversals (from reducing over size > 0) create avoidable memory and CPU overhead.
📊 Impact: Eliminates O(N) array memory allocations for
selectedSizeandhasSelection, and turnshasSelectionfrom a full O(N) collection iteration into an O(1) best-case / early-exit operation.🔬 Measurement: Run Time Profiler/Allocations instruments during UI updates (checking and unchecking checkboxes); view fewer
[ScanResult]heap allocations and fasterhasSelectiongetter resolution.PR created automatically by Jules for task 6607650057219304508 started by @acebytes