Skip to content

🎨 Palette: Add accessibility modifiers to collapsible section header#276

Open
acebytes wants to merge 1 commit into
mainfrom
palette-node-modules-a11y-9702155804377750044
Open

🎨 Palette: Add accessibility modifiers to collapsible section header#276
acebytes wants to merge 1 commit into
mainfrom
palette-node-modules-a11y-9702155804377750044

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Added accessibility modifiers (.accessibilityElement(children: .combine), .accessibilityLabel, .accessibilityValue, .accessibilityHint) to the NodeModulesSection header.
🎯 Why: The custom section header mixes text and icons. Without these modifiers, VoiceOver reads each component separately, failing to convey that it functions as a single interactive element with an expandable/collapsible state.
📸 Before/After: N/A (Non-visual accessibility improvement)
♿ Accessibility: Screen reader users will now correctly hear the header as a single button, its current state (Expanded/Collapsed), and instructions on how to toggle it.


PR created automatically by Jules for task 9702155804377750044 started by @acebytes

Added `.accessibilityElement(children: .combine)`, `.accessibilityLabel`,
`.accessibilityValue`, and `.accessibilityHint` to the custom collapsible
section header button in `NodeModulesSection.swift` so screen readers
announce it as a single interactive element with an expandable state rather
than disjointed fragments.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant