🎨 Palette: Add VoiceOver support for expandable sections#273
Conversation
- Added `accessibilityElement(children: .combine)` to `NodeModulesSection` header button - Provided explicit `accessibilityLabel` incorporating node count and total size - Added dynamic `accessibilityValue` indicating expanded/collapsed state - Added `accessibilityHint` to clarify interaction for VoiceOver users Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added accessibility modifiers to the
NodeModulesSectionheader button to combine elements and report its expanded/collapsed state.🎯 Why: Without these modifiers, VoiceOver reads the icons and text individually, creating a fragmented experience, and fails to announce whether the section is currently expanded or collapsed.
📸 Before/After: N/A (Non-visual VoiceOver improvement)
♿ Accessibility: Applied
.accessibilityElement(children: .combine),.accessibilityLabel,.accessibilityValue, and.accessibilityHintto ensure VoiceOver properly reads the header as a unified toggle switch.PR created automatically by Jules for task 17825558723300480975 started by @acebytes