⚡ Bolt: [performance improvement] Parallelize removeContents for faster bulk deletion#270
⚡ Bolt: [performance improvement] Parallelize removeContents for faster bulk deletion#270acebytes wants to merge 1 commit into
Conversation
…ing a sliding-window TaskGroup and GCD. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Modified
CacheCleaner.removeContentsto execute directory content deletions concurrently usingwithThrowingTaskGroup. It uses a sliding window (max 8) and offloads the synchronousFileManager.removeItemcalls to GCD (DispatchQueue.global) using continuations.🎯 Why: Previously, deleting directories with many files (e.g., node_modules, DerivedData) used a sequential
forloop calling synchronousremoveItem. This resulted in O(N) blocking disk I/O on the thread, slowing down cache evictions and potentially blocking the actor/executor.📊 Impact: Significantly accelerates bulk deletion of large directories by parallelizing up to 8 filesystem operations simultaneously while explicitly avoiding starvation of the Swift cooperative thread pool.
🔬 Measurement: Observe a substantial reduction in total cleanup time when clearing caches with extremely high file counts, such as Xcode DerivedData or nested Node.js project dependencies.
PR created automatically by Jules for task 3198037499954523536 started by @acebytes