ci: build wheels for all Python versions on macOS/Windows #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maturin's auto-discovery only found Python 3.13 on macOS/Windows, resulting in missing wheels for py3.9-3.12. Users on these platforms fell back to source builds which failed due to edition2024 in transitive dev-dependencies. Add explicit interpreter flags for macOS and Windows builds, matching the pattern already used for Linux. Before: 13 wheels (missing macOS py3.9-3.12, Windows py3.9-3.12) After: 25 wheels (full coverage)
27Bslash6
force-pushed
the
fix/wheel-builds-all-platforms
branch
from
c3caf2f to
5de46b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Users on Windows/macOS with Python 3.9-3.12 had no pre-built wheels, forcing source builds which failed due to
homecrate 0.5.12 requiring Rust edition 2024 (Cargo 1.85+, not yet stable).Solution
Maturin's
--find-interpreterauto-discovery is unreliable with multiple Python versions fromsetup-python. Explicit-i python3.Xflags ensure all versions get wheels.Impact