fix: use AliasChoices for REDIS_URL env var fallback #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REDIS_URL was being ignored because config was read in two places: - decorator.py checked REDIS_URL via os.environ.get() - RedisBackendConfig used pydantic-settings with CACHEKIT_ prefix The connection pool always read from RedisBackendConfig.from_env() which only checked CACHEKIT_REDIS_URL, falling back to localhost:6379. Fix uses pydantic-settings AliasChoices for proper env var priority: CACHEKIT_REDIS_URL > REDIS_URL > localhost:6379 (default) This is the declarative pydantic-settings approach vs manual os.environ.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDIS_URL was being ignored because config was read in two places:
The connection pool always read from RedisBackendConfig.from_env()
which only checked CACHEKIT_REDIS_URL, falling back to localhost:6379.
Fix uses pydantic-settings AliasChoices for proper env var priority:
CACHEKIT_REDIS_URL > REDIS_URL > localhost:6379 (default)
This is the declarative pydantic-settings approach vs manual os.environ.