Fix/failed init #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no plugins are configured to be started in the config file, apps start up, register no plugins, and do nothing. This is almost guaranteed to be wrong behavior in all situations, so it should be easy to specify some plugins that should always be started. This commit makes this so.
By listing headers among the sources, we don't confuse cmake at all since it knows better than to compile those, but we do make life easier on IDEs with CMake support, since the IDE will now pick up the headers as more source code for the project.
typo fix and two other small format fixes
typo fix
typo fix
Updated status messages output from CMake to reflect actual project name
Version handling, required to resolve #664
Add integer version number as well.
when the io_serv is stopped it may still own std::functions/lambdas that have captured data in them. If this captured data relies on another system like a logging system, for instance, waiting for destructors to be called by the atexit call may result in them accessing a destroyed system. By explicitly resetting the io_serve after shutdown we in turn release any resources it has while the systems are still alive and well
explicitly destroying io_serv at the end of shutdown
Add logging configuration path and clean up version variables.
Will rearrange later.
Remove semicolon disabling logconf option and default logging filename.
Move default location of logging.json to data directory.
Remove shadowed variable breaking config filename customization.
…g-1109 Error and exit on missing explicit config file. Resolves #1109.
boost filesystem uses boost system. Set the link order accordingly. Fixes boost 1.66 linkage on Linux with ld.
Fix boost library link ordering
Use standard endline. Regularize capitalization of CMake directives. Revise CMake installation with an eye toward more modern versions of CMake. Set explicit installation directory permissions so it works regardless of user's umask.
Add independent config directory and let users set default dirs.
Now shows (for example) # Track only transactions whose scopes involve the listed accounts. Default is to track all transactions. (eosio::account_history_plugin) # filter_on_accounts = Instead of # Track only transactions whose scopes involve the listed accounts. Default is to track all transactions. # filter_on_accounts = Which makes it a little easier to determine the context of the config option and description
Add plugin per config option in config file descriptions
Use CMake standard variables to install.
Some of our plugins will throw an exception on startup. For example, the http or net plugin will throw if it can’t bind to an address. Exceptions thrown at this stage are uncaught and cause the process to exit. However, in the process of unwinding the stack to exit, application’s dtor will call all of the already started plugins dtors. Some of these plugins don’t handle the case where their dtor is called without shtudown() being called on the plugin first. Result can be a (benign, but still embarrassing) crash on exit. Change appbase so that any exception thrown during startup() is caught, then all plugins shutdown, then exception is rethrown so that the app continues to exit.
When a plugin throws during startup, cleanup
Add an option to print the default configuration template. This could be useful to packagers (to create an /etc/ template without making /etc writable) or for users to see a diff of their config.ini compared to future defaults.
Add option to print default configuration template
…ystem See https://svn.boost.org/trac10/ticket/8535 Also remove config options count check: defaulted options always have a nonzero count.
…pace-2198 Work around boost defect at intersection of program_options and filesystem
…duplicated/copied
…thods add channels and methods
…nclude explicitly include typeindex headers
made it easier to use different dispatch policies made it possible to have void methods
…rst-provider-policy Void methods and first-provider dispatch policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.