Fix an off-by one assertion in Wasmtime#13313
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
Fix an off-by one assertion in Wasmtime#13313alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
When switching off a fiber in Wasmtime there's a guard check to ensure that the `CallThreadState` is no longer present on the stack that we're switching from. This assertion has an off-by-one that's technically unreachable in practice but the check is still incorrect. Use a slightly more idiomatic check to resolve this very minor issue.
github-actions
Bot
added
the
wasmtime:api
pchickey
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching off a fiber in Wasmtime there's a guard check to ensure that the
CallThreadStateis no longer present on the stack that we're switching from. This assertion has an off-by-one that's technically unreachable in practice but the check is still incorrect. Use a slightly more idiomatic check to resolve this very minor issue.