Minor updates/improvements to wast subcommand#13309
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
Minor updates/improvements to wast subcommand#13309alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
wast subcommand#13309alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
* Add `--ignore-error-messages` as a CLI flag instead of only looking for "spec_testsuite" in the path of tests. Do some plumbing to ensure all spec tests, even component model ones, ignore error messages due to divergences over time. This "fixes" two upstream tests as Wasmtime rejects them due to an error message. * Auto-enabled backtrace details to get printed out when DWARF information is emitted. There's not really any purpose in emitting DWARF and then not using it, and the backtrace looks much nicer by default. This gives line numbers in backtraces for `wast` files by default, which is a nice perk.
alexcrichton
requested review from
a team,
cfallin and
dicej
and removed request for
a team and
dicej
pchickey
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--ignore-error-messagesas a CLI flag instead of only looking for "spec_testsuite" in the path of tests. Do some plumbing to ensure all spec tests, even component model ones, ignore error messages due to divergences over time. This "fixes" two upstream tests as Wasmtime rejects them due to an error message.Auto-enabled backtrace details to get printed out when DWARF information is emitted. There's not really any purpose in emitting DWARF and then not using it, and the backtrace looks much nicer by default. This gives line numbers in backtraces for
wastfiles by default, which is a nice perk.