[Cranelift] add type-aware rotate operations#12764
Open
bongjunj wants to merge 4 commits intobytecodealliance:mainfrom
Open
[Cranelift] add type-aware rotate operations#12764bongjunj wants to merge 4 commits intobytecodealliance:mainfrom
bongjunj wants to merge 4 commits intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
Mar 13, 2026
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Thanks! A few thoughts below but the logic generally looks good to me.
Contributor
Author
|
Thanks for the review!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12759. Rotation operations are sensitive to type width; therefore their semantics should change per the operands' type rather than being fixed to
u64,u32, and so on.