Define a fallible-allocation-only version of PrimaryMap in wasmtime_environ::collections
#12396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move allocation helpers from `wasmtime_environ::collections` to `wasmtime_core::alloc`, with a re-export through the old location for higher-level helpers.
…e_environ::collections`
alexcrichton
approved these changes
Jan 22, 2026
| where | ||
| K: EntityRef, | ||
| { | ||
| /// Create a new empty map. |
Member
There was a problem hiding this comment.
For docs I'd recommend having a simple:
/// Same as [`cranelift_entity::PrimaryMap::new`]
to avoid duplication
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "cranelift", "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12395 and #12384
Part of #12069