Add fallible allocation methods to cranelift_bitset::CompoundBitSet
#12381
Conversation
fitzgen
force-pushed
the
fallible-alloc-for-compound-bit-set
branch
from
0957138 to
92ff7d0
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "cranelift", "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
And move allocation helpers from `wasmtime_environ::collections` to `wasmtime_core::alloc`, with a re-export through the old location for higher-level helpers.
fitzgen
requested review from
alexcrichton and
pchickey
and removed request for
a team
There was a problem hiding this comment.
Personally I'd say that wasmtime-{math,error} could get folded in here too (probably in a future PR), but wanted to confirm/deny your thoughts on that?
There was a problem hiding this comment.
I'm half of the mind that there is no need to eagerly merge crates if we don't have any reason to do so, but I don't feel strongly at all. Anyways, I don't think there is anything blocking that, but I don't have any plans on doing it myself.
|
Oh also, along the lines of crate consolidation, can you add this crate to the Miri-tested crates in CI? I'll do a follow-up to merge our core utilities into this crate |
I'm doing this in #12398 |
2 participants
Part of #12069