Skip to content

update command for analyzing new item names to use git diff instead of git show #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lum1n0us merged 1 commit into from
May 8, 2026
+4 −7
Merged

update command for analyzing new item names to use git diff instead of git show #4939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ci/coding_guidelines_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,20 +219,17 @@ def analysis_new_item_name(root: Path, commit: str) -> bool:

For any directory name in the repo, it is required to use '-' to replace '_'.
"""
GIT_SHOW_CMD = f"git show --oneline --name-status --diff-filter A {commit}"
GIT_DIFF_CMD = f"git diff --name-status --diff-filter=A {commit}"
try:
invalid_items = True
output = subprocess.check_output(
shlex.split(GIT_SHOW_CMD), cwd=root, universal_newlines=True
shlex.split(GIT_DIFF_CMD), cwd=root, universal_newlines=True
)
if not output:
return True

NEW_FILE_PATTERN = "^A\s+(\S+)"
for line_no, line in enumerate(output.split("\n")):
# bypass the first line, usually it is the commit description
if line_no == 0:
continue
NEW_FILE_PATTERN = r"^A\s+(\S+)"
for line in output.split("\n"):

if not line:
continue
Expand Down