add: more unit cases for the shared heap#4938
Open
qinyiling wants to merge 3 commits intobytecodealliance:mainfrom
Open
add: more unit cases for the shared heap#4938qinyiling wants to merge 3 commits intobytecodealliance:mainfrom
qinyiling wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
TianlongLiang
changed the title
TianlongLiang
changed the title
TianlongLiang
force-pushed
the
nvu_val_case
branch
2 times, most recently
from
fc4e597 to
a641de3
Compare
lum1n0us
requested changes
May 8, 2026
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
I would suggest squashing all 3 commits and fixing the CI failure.
lum1n0us
reviewed
May 8, 2026
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
Would you mind rebasing this PR to the main branch and triggering a new round of CI?
TianlongLiang
force-pushed
the
nvu_val_case
branch
from
a641de3 to
1ef086f
Compare
Contributor
|
Rebase done, waiting for CI to finish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the nvu_val_case changes for NVU validation