gc: complete common heap type coverage #4801
Open
+28
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylo5aby
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
kylo5aby
changed the title
Signed-off-by: zhenweijin <zhenwei.jin@intel.com>
kylo5aby
force-pushed
the
gc-type
branch
2 times, most recently
from
de94780 to
bd679be
Compare
lum1n0us
added
the
breaking-change
lum1n0us
reviewed
Jan 22, 2026
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
might want to mention that both exn(0x74 or -12 as S7) and noexn(0x69 or -23 as S7) are not suppoted yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the coverage of common heap types by extending the range check
in
wasm_is_refheaptype_common()to include HEAP_TYPE_NOEXTERN andHEAP_TYPE_NOFUNC. Also fix the assertion condition in
wasm_ref_type_set_heap_type()which had an incorrect range check that was always false.