Fix potential memcpy overlap issue in RECOVER_BR_INFO for i64/v128 copy #4797
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhenweijin <zhenwei.jin@intel.com>
kylo5aby
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
lum1n0us
added
the
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying single i64 or V128 values in
RECOVER_BR_INFO, source anddestination memory regions may overlap, causing memcpy-param-overlap errors
Use temporary variables to separate read and write operations, preventing
the overlap issue.
This fix references the approach used in the other path (when arity != 1), which calls
copy_stack_values, that function explicitly handles memcpy overlap.