Open
Conversation
Given the definition of the LIB_RATS vars, this line should be fixed in this way.
dzobbe
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
requested changes
Apr 24, 2025
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
Could you please share which release of SGX and SGXSSL you are using?
Contributor
Author
I am using the SGX sdk v2.25 SGXSSL and 3.0_Rev2 |
Contributor
|
Understood. Could you please update samples/sgx-ra/README.md based on the PR modifications? |
Contributor
Author
done! |
| -L$(LIB_RATS_SRC)/verifiers/sgx-ecdsa-qve \ | ||
| -L$(SGX_SSL)/lib64 \ | ||
| -L$(VMLIB_BUILD_DIR)/external/libcbor/src/libcbor/lib \ | ||
| -L$(LIB_RATS_SRC)/crypto_wrappers/openssl \ |
Contributor
There was a problem hiding this comment.
duplicate line with 166
| $ cd ../ | ||
| $ git clone https://github.com/intel/intel-sgx-ssl.git | ||
| $ wget https://www.openssl.org/source/openssl-1.1.1v.tar.gz -O intel-sgx-ssl/openssl_source/openssl-1.1.1v.tar.gz | ||
| $ wget https://www.openssl.org/source/openssl-3.0.14.tar.gz -O intel-sgx-ssl/openssl_source/openssl-3.0.14.tar.gz |
Contributor
There was a problem hiding this comment.
When I try to make all, it requires openssl version to be 3.1.x, do you think it's a problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the definition of the LIB_RATS vars, this line should be fixed in this way.