Remove cfgs based on nonexisting features#127
Remove cfgs based on nonexisting features#127pmikolajczyk41 wants to merge 4 commits intobytecodealliance:mainfrom
Conversation
| /// | ||
| /// See also https://en.cppreference.com/w/c/language/arithmetic_types | ||
| #[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)] | ||
| #[cfg_attr(feature = "rust_1_40", non_exhaustive)] |
There was a problem hiding this comment.
rust_1_40 is set in the build script when the rustc version is at least 1.40.
| #![cfg_attr( | ||
| feature = "cargo-clippy", | ||
| warn( | ||
| clippy::float_arithmetic, | ||
| clippy::mut_mut, | ||
| clippy::nonminimal_bool, | ||
| clippy::option_map_unwrap_or, | ||
| clippy::option_map_unwrap_or_else, | ||
| clippy::print_stdout, | ||
| clippy::unicode_not_nfc, | ||
| clippy::use_self, | ||
| ) | ||
| )] |
There was a problem hiding this comment.
cargo-clippy is set when running cargo clippy.
|
my apologies @bjorn3; in that case, would you allow me to add |
|
Please add appropriate |
|
@bjorn3 for some reason I couldn't make it work with printing |
Removing almost 20 cfgs that were using nonexisting features (
rust_1_40andcargo-clippy). They were polluting build output with warnings.