Update pins for MSRV compatibility#1584
Merged
sunfishcode merged 1 commit intobytecodealliance:mainfrom Feb 15, 2026
Merged
Conversation
xtqqczze
changed the title
xtqqczze
force-pushed
the
unpin-ryu
branch
3 times, most recently
from
fbf17ac to
98dc424
Compare
xtqqczze
force-pushed
the
unpin-ryu
branch
4 times, most recently
from
23bc44e to
49ffe01
Compare
Contributor
Author
|
Check nightly-only targets (nightly) failures will be fixed by #1582 |
Member
|
Thanks! |
Contributor
Author
|
@sunfishcode any reason we don't use |
Member
|
Maintaining these pins is indeed a nuisance. But my experience in other projects is that maintaining a checked-in Cargo.lock is a nuisance too, with merge conflicts on Cargo.lock, PRs that accidentally include Cargo.lock, extra PR traffic for PRs that just bump Cargo.lock, PRs that bump Cargo.toml but forget to bump Cargo.lock, and so on. So I don't have a strong opinion either way. |
Contributor
Author
|
There are already more pins needed: #1585 Rust on Debian stable is currently 1.85, what is the strategy for increasing MSRV?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @sunfishcode