Skip to content

Conversation

@jeffcharles
Copy link
Collaborator

Description of the change

Tries to revert #1068.

Why am I making this change?

I noticed we don't seem to be triggering rebuilds of Wasm plugins when we should be both locally and in CI. So let's go back to an approach we have more confidence in.

Checklist

  • I've updated the default plugin import namespace and incremented the major version of javy-plugin-api if the QuickJS bytecode has changed.
  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli, javy-plugin, and javy-plugin-processing do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles marked this pull request as ready for review January 6, 2026 14:39
@saulecabrera
Copy link
Member

Actually, do you have a concrete run that showcases the issue? I've been changing the plugin and consuming it from the CLI and everything seems to be working fine.

@jeffcharles
Copy link
Collaborator Author

Actually, do you have a concrete run that showcases the issue?

The Build plugin step in https://github.com/bytecodealliance/javy/actions/runs/20728726021/job/59510898540 should've triggered a rebuild since I changed the import namespace in the source file for the plugin but it didn't which then causes a test in the next step to fail since the plugin still has the old namespace. I ran into a similar problem locally.

If CI doesn't restore the Wasm file from the cache, then everything works properly since it'll force a rebuild for the WASI targets. But if it does restore the file, then Make skips the rebuild.

@jeffcharles jeffcharles merged commit fecbe6e into main Jan 6, 2026
5 checks passed
@jeffcharles jeffcharles deleted the jc.fix-stale-targets3 branch January 6, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants