fix(url): make URLSearchParams record constructor spec compliant #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where byte replacement characters could result in duplicate entries when constructing
URLSearchParamsfrom a record.While current implementation follows the spec to the word:
using
params_append()directly happens before theUSVStringconversion so that keys that are supposed to collide after conversion can be added as separate entries.By using
params_set()we get the correct behavior without having to normalize the record beforehand.Extending
maybe_consume_sequence_or_recordwith separate sequence and record handlers allows applying different behavior.Passes 2 remaining tests for
URLSearchParamsconstructor.