Skip to content

fix: debug build output #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guybedford merged 1 commit into from
Mar 11, 2025
Merged

fix: debug build output #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ set(OUTPUT_NAME_DEBUG "starlingmonkey_embedding.debug.wasm")
set(OUTPUT_NAME_WEVAL "starlingmonkey_embedding_weval.wasm")

# Set the appropriate name based on current configuration
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
set(OUTPUT_FILENAME ${OUTPUT_NAME_DEBUG})
elseif(WEVAL)
set(OUTPUT_FILENAME ${OUTPUT_NAME_WEVAL})
Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ JCO ?= ./node_modules/.bin/jco
STARLINGMONKEY_SRC ?= StarlingMonkey

ifndef JCO
JCO = $(error No jco in PATH. Run npm install -g @bytecodealliance/jco)
JCO = $(error No jco found. Run npm install.)
endif

# ifndef WASM_OPT
Expand Down Expand Up @@ -52,3 +52,4 @@ clean:
rm -r obj
rm lib/spidermonkey-embedding-splicer.js
rm lib/starlingmonkey_embedding.wasm
rm lib/starlingmonkey_embedding.debug.wasm