Skip to content

Support passing arguments to the StarlingMonkey runtime #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guybedford merged 2 commits into from
Feb 21, 2025
Merged

Support passing arguments to the StarlingMonkey runtime #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b5503
Support passing arguments to the StarlingMonkey runtime
tschneidereit Feb 21, 2025
dd15578
tweaks
Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/componentize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,14 @@ export async function componentize(jsSource, witWorld, opts) {
witWorld = opts?.witWorld;
}
opts = opts || {};
const {
let {
sourceName = 'source.js',
preview2Adapter = preview1AdapterReactorPath(),
witPath,
worldName,
disableFeatures = [],
enableFeatures = [],
runtimeArgs,
aotCache = fileURLToPath(
new URL(`../lib/starlingmonkey_ics.wevalcache`, import.meta.url)
),
Expand Down Expand Up @@ -222,6 +223,10 @@ export async function componentize(jsSource, witWorld, opts) {
console.log('--- Wizer Env ---');
console.log(env);
}

let sourcePath = maybeWindowsPath(join(sourceDir, sourceName.slice(0, -3) + '.bindings.js'));
runtimeArgs = runtimeArgs ? `${runtimeArgs} ${sourcePath}` : sourcePath;

if (opts.enableAot) {
// Determine the weval bin path, possibly using a pre-downloaded version
let wevalBin;
Expand All @@ -247,9 +252,7 @@ export async function componentize(jsSource, witWorld, opts) {
{
stdio: [null, stdout, stderr],
env,
input: maybeWindowsPath(
join(sourceDir, sourceName.slice(0, -3) + '.bindings.js')
),
input: runtimeArgs,
shell: true,
encoding: 'utf-8',
}
Expand Down Expand Up @@ -284,9 +287,7 @@ export async function componentize(jsSource, witWorld, opts) {
{
stdio: [null, stdout, stderr],
env,
input: maybeWindowsPath(
join(sourceDir, sourceName.slice(0, -3) + '.bindings.js')
),
input: runtimeArgs,
shell: true,
encoding: 'utf-8',
}
Expand Down
5 changes: 5 additions & 0 deletions types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ interface ComponentizeOptions {
* To pass only a subset, provide an object with the desired variables
*/
env?: boolean | Record<string, string>,
/**
* Runtime arguments to provide to the StarlingMonkey engine initialization
* (see https://github.com/bytecodealliance/StarlingMonkey/blob/main/include/config-parser.h)
*/
runtimeArgs?: string,
}

/**
Expand Down
Loading