Refactor query helper initialization for clarity #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctQuery` to improve code clarity and remove redundant checks.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this horse.
.''
._.-.___.' (`\
//( ( `'
'/ )\ ).__. )
' <' `\ ._/'\
` \ \Files scanned
| File Path | Reviewed |
|---|---|
| src/InsertSelectQuery.php | ✅ |
| src/UpdateQuery.php | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlined the initialization of query helpers in
UpdateQueryandInsertSelectQuery. This improves code clarity and removes redundant checks, ensuring better maintainability. No changes to functionality have been made.Description by Korbit AI
What change is being made?
Refactor query helper initialization to separate DbDriver and DbHelper usage, update surrounding calls to consistently use a DbHelper instance for delimiting identifiers, pass the driver to sub-builds, and standardize literal type hints across UUID literal classes, plus adjust UpdateQuery setLiteral and join-table helper handling accordingly.
Why are these changes being made?
Clarify and unify how database drivers and helpers are handled across queries, reducing ambiguity and improving consistency when formatting identifiers and building nested queries. Minor type-hint standardization and minor behavior alignment to ensure literals and update queries integrate smoothly with the new helper-driven flow.