Skip to content

Allow config args to be not first#266

Closed
benjamin-fenker wants to merge 1 commit intobw2:masterfrom
benjamin-fenker:master
Closed

Allow config args to be not first#266
benjamin-fenker wants to merge 1 commit intobw2:masterfrom
benjamin-fenker:master

Conversation

@benjamin-fenker
Copy link
Copy Markdown

Resolves #265

@tbooth
Copy link
Copy Markdown
Collaborator

tbooth commented Apr 14, 2025

I see what this PR is getting at but I feel like it might not work in all cases. I think we definitely need some extra tests before accepting this change.

Also, some nitpicks:

  • Avoid using a list comprehension for side effects. The first one is fine, but the second should be an actual for loop
  • The comments in the code should be changed in line with the code changes

@bw2
Copy link
Copy Markdown
Owner

bw2 commented Mar 8, 2026

Closing as outdated.

@bw2 bw2 closed this Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Positional config file arguments do not work when config file arg is not first

3 participants