feat(helm): add resizePolicy and dnsConfig to pod spec#1001
Conversation
- Container-level resizePolicy for in-place vertical scaling (Kubernetes 1.27+ with InPlacePodVerticalScaling feature gate) - Pod-level dnsConfig for tuning DNS options such as ndots - Both default to empty so existing manifests stay unchanged Signed-off-by: younsl <cysl@kakao.com>
|
Hey @younsl, thank you for your contribution. I'll have a look today. 😃👍 |
|
Thanks @burningalchemist! Quick note: I skipped the chart version bump in this PR to follow the existing convention where feature/fix PRs land first and a separate |
|
Hey @younsl, if you don't mind bumping up the version, that'd be great. Current workflow is a bit tricky but helps with testing anyway. Maybe I revisit it in the future. For now, let's just bump up the version to |
Bump chart version from 0.17.7 to 0.18.0 for the new resizePolicy and dnsConfig features, and regenerate README via `make gen_docs`. Per maintainer request: #1001 (comment) Signed-off-by: younsl <cysl@kakao.com>
|
Ready to merge |
|
@younsl released! Thanks again! 🙌 |
|
@burningalchemist This SQL Exporter has been running 24x7 in production at our payments company. Primarily used for visualizing DB connections and DB process lists. Thank you for maintaining such a great project. |
Summary
Adds two opt-in pod spec fields to the Helm chart:
resizePolicy— container-level resize policy for in-place vertical scaling (Kubernetes 1.27+ withInPlacePodVerticalScalingfeature gate). Lets operators avoid pod restarts on CPU/memory resize when desired.dnsConfig— pod-level DNS configuration, commonly used to tunendotsand cut down on unnecessary DNS lookups inside the cluster.Both default to empty (
[]/{}) and are rendered withwithguards, so existing manifests are unchanged.Changes
helm/values.yaml: addresizePolicyanddnsConfigwith documentation comments and example values for CPU / memory /ndots.helm/templates/deployment.yaml: renderresizePolicyunder the container spec (afterresources) anddnsConfigunder the pod spec (aftertolerations).helm/README.md: regenerated viahelm-docs.Example
Test plan
helm lint helm/passeshelm templatewith default values: neitherresizePolicynordnsConfigis rendered (no regression)helm templatewith the example above:resizePolicyplaced at container scope,dnsConfig.options[].name=ndotsat pod scopehelm-docsregenerated; new rows added tohelm/README.mdNote: chart version intentionally not bumped — leaving it to a separate release bump PR, consistent with project history.