Skip to content

feat(helm): add resizePolicy and dnsConfig to pod spec#1001

Merged
burningalchemist merged 2 commits into
burningalchemist:masterfrom
younsl:feat/helm-resize-policy-ndots
May 19, 2026
Merged

feat(helm): add resizePolicy and dnsConfig to pod spec#1001
burningalchemist merged 2 commits into
burningalchemist:masterfrom
younsl:feat/helm-resize-policy-ndots

Conversation

@younsl
Copy link
Copy Markdown
Contributor

@younsl younsl commented May 19, 2026

Summary

Adds two opt-in pod spec fields to the Helm chart:

  • resizePolicy — container-level resize policy for in-place vertical scaling (Kubernetes 1.27+ with InPlacePodVerticalScaling feature gate). Lets operators avoid pod restarts on CPU/memory resize when desired.
  • dnsConfig — pod-level DNS configuration, commonly used to tune ndots and cut down on unnecessary DNS lookups inside the cluster.

Both default to empty ([] / {}) and are rendered with with guards, so existing manifests are unchanged.

Changes

  • helm/values.yaml: add resizePolicy and dnsConfig with documentation comments and example values for CPU / memory / ndots.
  • helm/templates/deployment.yaml: render resizePolicy under the container spec (after resources) and dnsConfig under the pod spec (after tolerations).
  • helm/README.md: regenerated via helm-docs.

Example

resizePolicy:
  - resourceName: cpu
    restartPolicy: NotRequired
  - resourceName: memory
    restartPolicy: RestartContainer

dnsConfig:
  options:
    - name: ndots
      value: "2"

Test plan

  • helm lint helm/ passes
  • helm template with default values: neither resizePolicy nor dnsConfig is rendered (no regression)
  • helm template with the example above: resizePolicy placed at container scope, dnsConfig.options[].name=ndots at pod scope
  • helm-docs regenerated; new rows added to helm/README.md

Note: chart version intentionally not bumped — leaving it to a separate release bump PR, consistent with project history.

- Container-level resizePolicy for in-place vertical scaling
  (Kubernetes 1.27+ with InPlacePodVerticalScaling feature gate)
- Pod-level dnsConfig for tuning DNS options such as ndots
- Both default to empty so existing manifests stay unchanged

Signed-off-by: younsl <cysl@kakao.com>
@burningalchemist
Copy link
Copy Markdown
Owner

Hey @younsl, thank you for your contribution. I'll have a look today. 😃👍

@younsl
Copy link
Copy Markdown
Contributor Author

younsl commented May 19, 2026

Thanks @burningalchemist! Quick note: I skipped the chart version bump in this PR to follow the existing convention where feature/fix PRs land first and a separate Bump up helm chart to x.y.z PR handles the release — happy to adjust if you'd prefer it bundled.

@burningalchemist
Copy link
Copy Markdown
Owner

Hey @younsl, if you don't mind bumping up the version, that'd be great. Current workflow is a bit tricky but helps with testing anyway. Maybe I revisit it in the future.

For now, let's just bump up the version to 0.18.0 since there are new features. Could you also run make gen_docs from the helm directory afterwards? 🙂

Bump chart version from 0.17.7 to 0.18.0 for the new resizePolicy and
dnsConfig features, and regenerate README via `make gen_docs`.

Per maintainer request: #1001 (comment)

Signed-off-by: younsl <cysl@kakao.com>
@younsl
Copy link
Copy Markdown
Contributor Author

younsl commented May 19, 2026

Ready to merge

@burningalchemist burningalchemist merged commit d89e3a3 into burningalchemist:master May 19, 2026
4 checks passed
@burningalchemist
Copy link
Copy Markdown
Owner

@younsl released! Thanks again! 🙌

@younsl
Copy link
Copy Markdown
Contributor Author

younsl commented May 19, 2026

@burningalchemist This SQL Exporter has been running 24x7 in production at our payments company. Primarily used for visualizing DB connections and DB process lists. Thank you for maintaining such a great project.

@younsl younsl deleted the feat/helm-resize-policy-ndots branch May 19, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants