Skip to content

Conversation

@OzanAlpay
Copy link
Contributor

Running docker containers as user instead of root feature implemented.

@bulwahn
Copy link
Owner

bulwahn commented Jul 29, 2018

@OzanAlpay Did you see that Codacy is pointing out that this is not good. Can you check if it possible to write the bash expression in such a way that it works and Codacy does not complain? You need probably need to go through the bash documentation to find out which possibilities there are for quoting.

@OzanAlpay
Copy link
Contributor Author

I will look and fix this problem soon

Whoami problem, which occurs when running docker containers as a user, solved.
@OzanAlpay OzanAlpay force-pushed the run-docker-as-user branch from 1b66888 to a0444f0 Compare August 1, 2018 13:31
@OzanAlpay
Copy link
Contributor Author

I have looked that warning again, and interestingly find-out (as codacy complained) even without any ' it works well.

I analyzed outputs after called script with different kernel-configurations and saw that it is working. Such as after calling with allyesconfig, I saw output:

scripts/kconfig/conf  --allyesconfig Kconfig

So I updated my request according to that without using any '. I will also update my other pull request( #18 ), that Codacy complained about.
By the way my home setup is:
GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)
Docker version 18.03.1-ce, build 9ee9f40

@bulwahn
Copy link
Owner

bulwahn commented Mar 8, 2019

This change was included into master. So, we close this pull request successfully.

@bulwahn bulwahn closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants