Skip to content

Conversation

@justdave
Copy link
Member

Details

  • Cleaned some of the scripts related to docker builds, got the same "does docker exist?" sanity code in all of them now.
  • Converted the Release Tests GitHub Action to use a Docker image instead of running scripts directly on a GitHub test runner.
  • Moved the Release Tests action into the ci.yml file and removed releases.yml (getting all of the tests listed in the same place, since they all run on the same push/branch criteria anyway.
  • Added a script you can run with sh docker/run-tests-in-docker.sh which lets you pick a test to run and runs it locally.

Additional info

dannycolin
dannycolin previously approved these changes Dec 17, 2025
Copy link

@dannycolin dannycolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected.

As a follow-up bug, I'd suggest running shellcheck and aligning the code style either on POSIX sh or Bash instead of having a mixed style.

@justdave justdave requested a review from dannycolin December 17, 2025 05:05
@justdave
Copy link
Member Author

Note that the 6 pending checks are pending because they're listed as required for the branch and they don't exist to run them anymore because I renamed them. I can't fix it until this PR lands though, so we'll have to override the test pass requirement to land this, and then I can go fix it.

@justdave justdave merged commit fcd8aa8 into main Dec 17, 2025
7 checks passed
@justdave justdave deleted the patch-2005381-harmony branch December 17, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants