-
-
Notifications
You must be signed in to change notification settings - Fork 29
[Harmony] Bug 2005381: Clean up docker configs, run tests locally easier #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dannycolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected.
As a follow-up bug, I'd suggest running shellcheck and aligning the code style either on POSIX sh or Bash instead of having a mixed style.
|
Note that the 6 pending checks are pending because they're listed as required for the branch and they don't exist to run them anymore because I renamed them. I can't fix it until this PR lands though, so we'll have to override the test pass requirement to land this, and then I can go fix it. |
Details
sh docker/run-tests-in-docker.shwhich lets you pick a test to run and runs it locally.Additional info