Conversation
bugale
force-pushed
the
bugale/stack_trace
branch
4 times, most recently
from
9ce7e42 to
7833908
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
bugale
force-pushed
the
bugale/stack_trace
branch
from
7833908 to
0c941d6
Compare
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
bugale
force-pushed
the
bugale/stack_trace
branch
from
0c941d6 to
10ff9d1
Compare
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
bugale
force-pushed
the
bugale/stack_trace
branch
5 times, most recently
from
a568159 to
c03d759
Compare
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
bugale
force-pushed
the
bugale/stack_trace
branch
5 times, most recently
from
5e6843b to
1c2dfd5
Compare
bugale
force-pushed
the
bugale/stack_trace
branch
9 times, most recently
from
941380d to
a9a88de
Compare
bugale
force-pushed
the
bugale/stack_trace
branch
9 times, most recently
from
c36830b to
0cdd97e
Compare
bugale
force-pushed
the
bugale/stack_trace
branch
from
0cdd97e to
d611a85
Compare
| return { size: offset, name, from(addr) { return new Struct(addr); } }; | ||
| } | ||
|
|
||
| function defer(fn, name) { |
There was a problem hiding this comment.
no-unused-vars: 'defer' is defined but never used. Allowed unused vars must match /^exports$/u. (eslint)
| }; | ||
| } | ||
|
|
||
| function array(type, length) { |
There was a problem hiding this comment.
no-unused-vars: 'array' is defined but never used. Allowed unused vars must match /^exports$/u. (eslint)
There was a problem hiding this comment.
Copilot reviewed 14 out of 21 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- .vscode/settings.json: Language not supported
- Install.ps1: Language not supported
- Manifest/Manifest.1.xml: Language not supported
- Manifest/config.xml: Language not supported
- bugalua/package.json: Language not supported
- setup.cfg: Language not supported
- tests/requirements.txt: Language not supported
Comments suppressed due to low confidence (2)
tests/test_memory_usage.py:27
- Parsing the output by splitting on ':' and accessing index 2 is fragile; consider adding validation to ensure the expected format before conversion.
memory_used = int(output.split(':')[2].strip(), 0)
bugalua/bugalua.js:3
- [nitpick] Redefining 'console' may cause confusion with the global console object; consider using a more descriptive name such as 'debugConsole' for clarity.
const console = { log: (...args) => host.diagnostics.debugLog(...args, '\n') };
| ''') | ||
| logger.debug('Running windbg commands: %s', commands) | ||
| proc = subprocess.run([r'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\cdb.exe', '-z', dump, '-c', f'$<{commands_file.name}'], |
There was a problem hiding this comment.
The WinDbg executable path is hardcoded; consider making the path configurable to accommodate different environments or future updates.
| proc = subprocess.run([r'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\cdb.exe', '-z', dump, '-c', f'$<{commands_file.name}'], | |
| windbg_path = os.getenv('WINDBG_PATH', r'C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\cdb.exe') | |
| if not os.path.isfile(windbg_path): | |
| raise FileNotFoundError(f"WinDbg executable not found at {windbg_path}. Please set the WINDBG_PATH environment variable.") | |
| proc = subprocess.run([windbg_path, '-z', dump, '-c', f'$<{commands_file.name}'], |
1 participant
No description provided.