Add zero test for ir package
#645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doriable
commented
Dec 24, 2025
Comment on lines
+48
to
+52
| // node is a helper interface to enforce [id.Node] types. | ||
| type node[T any] interface { | ||
| zeroable | ||
| ID() id.ID[T] | ||
| } |
Member
Author
There was a problem hiding this comment.
Wasn't sure if it's entirely necessary to enforce id.Nodes in this way.
Similarly, I'm not sure if it is necessary to enforce zeroable either, since *ir.File for example would not conform.
Comment on lines
+17
to
+19
| testZeroAny[*ir.File](t) | ||
| testZeroAny[ir.Import](t) // Import embeds *ir.File | ||
| testZeroAny[*ir.Imports](t) |
Member
Author
There was a problem hiding this comment.
Related to the question below, this currently doesn't test ir.Ref[T] for *ir.File and ir.Import. If we don't need to enforce the IsZero interface, and these are valid values for ir.Ref, then I can simplify this.
Comment on lines
+575
to
+580
| // If the element is empty, this returns -1. | ||
| func (e Element) ValueNodeIndex() int { | ||
| if e.IsZero() { | ||
| return -1 | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Want to make sure this behaviour is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a zero test for the
irpackage, similar tothe one for the
astpackage to ensure that getters/accessorson zero values return zero values and do not panic. It also fixes
panics on zero values.