Skip to content

Hyperlinks render incorrectly #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1AhmedYasser wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −1
Open

Hyperlinks render incorrectly #997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion GUI/src/services/service-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,8 +751,12 @@

const spacePlaceholder = '___SPACE___';
const rawMessage = typeof parentNode.data.message === 'string' ? decodeHtmlEntities(parentNode.data.message) : '';
const rawMessageWithSpaceholders = rawMessage
.replaceAll('{{', '${')
.replaceAll('}}', '}')
.replaceAll(/(<[^>]+>)|( )/g, (_match, tag) => (tag === undefined ? spacePlaceholder : tag));

Check failure on line 757 in GUI/src/services/service-builder.ts

View workflow job for this annotation

GitHub Actions / frontend-lint / run-check 

Make sure the regex used here, which is vulnerable to super-linear runtime due to backtracking, cannot lead to denial of service
const markdownMessage = htmlToMarkdown
.translate(rawMessage.replace('{{', '${').replace('}}', '}').replaceAll(' ', spacePlaceholder))
.translate(rawMessageWithSpaceholders)
.replaceAll(spacePlaceholder, ' ')
.replaceAll(/\\([-~>[\]_*#().!`=<\\])/g, String.raw`\\$1`);

Expand Down
Loading