Remove public private endpoint distiction#989
Open
ruwinirathnamalala wants to merge 17 commits intobuerokratt:devfrom
Open
Remove public private endpoint distiction#989ruwinirathnamalala wants to merge 17 commits intobuerokratt:devfrom
ruwinirathnamalala wants to merge 17 commits intobuerokratt:devfrom
Conversation
Pull from buerokratt/dev
5 tasks
This was referenced May 5, 2026
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#951
Overview
Removes the public/private endpoint distinction (
is_common) from the endpoint data model. Previously, endpoints were marked as either "public" (common) or "private" per service — this concept is eliminated entirely at the GUI, DSL, and database levels. All endpoints are now treated uniformly without a visibility flag.GUI (
GUI/src/)API Constants
resources/api-constants.ts— RenamedgetCommonEndpoints()→getAllEndpoints(); URL changed from/endpoints/commonto/endpoints/allStores
store/new-services.store.ts:loadCommonEndpoints→loadAllEndpoints(interface + implementation)isCommonfrom store state,resetState, andloadAllEndpointsresponse mappingisCommon(set fromserviceResponse.data.isCommoninloadService) — service-level visibility is out of scope for this ticketpageSize→page_sizeto match Ruuter allowliststore/api-registry.store.ts:loadEndpointscall:getCommonEndpoints()→getAllEndpoints()isCommon: row.isCommonfrom endpoint mapperisCommon: endpoint.isCommon ?? truefromcopyEndpointComponents
components/ApiEndpointCard/index.tsx:showCommonSwitchandonCommonChangepropsSwitchfrom importscomponents/Flow/EdgeTypes/AddEndpointModal.tsx:isCommonEndpointstatepassedEndpoint.isCommon = isCommonEndpointfromhandleSaveonCommonChangeprop from<ApiEndpointCard>Services
services/endpoint.service.ts— Removedendpoint.isCommon = endpoint.isCommon ?? falsedefault assignmentPages
pages/ServiceFlowPage.tsx— Updated call:loadCommonEndpoints→loadAllEndpointsTypes
types/endpoint/endpoint-data.ts— RemovedisCommon?: booleanfieldtypes/service.ts— RemovedisCommonfromService.endpointsPick type (service-levelreadonly isCommon: booleanonServiceinterface retained)i18n
i18n/en/common.json— Removed"publicEndpoint"keyi18n/et/common.json— Removed"publicEndpoint"keyRuuter (
DSL/Ruuter/)POST/endpoints/all.yml(renamed fromcommon.yml)common.yml→all.ymlget_common_endpoints→get_paginated_endpoints.../get_common_endpoints→.../get_paginated_endpoints"Returns all endpoints with pagination, sorting and search support"Resql (
DSL/Resql/services/POST/endpoints/)get_paginated_endpoints.sql(renamed fromget_common_endpoints.sql)is_commonfilter was ever appliedcreate_endpoint.sql(modified)is_commoncolumn from INSERT statement.update_endpoint.sql(modified)is_common = :isCommonfrom UPDATE SET clauseLiquibase Migrations (
DSL/Liquibase/)20260504120000_remove-is-common-from-endpointsis_commoncolumn from theendpointstableIncludes rollback script:
ALTER TABLE endpoints ADD COLUMN IF NOT EXISTS is_common BOOLEAN NOT NULL DEFAULT FALSE.