Skip to content

Instance process with parameters array #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minterior wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Instance process with parameters array #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c00c16
Instantiate Process with an array of command and parameters
minterior Mar 13, 2020
9bc0ef1
Remove sprintf function calls for understandability
minterior Mar 13, 2020
d9e6cbf
Add missing requirement symfony/process
minterior Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"beberlei/assert": "~2.7",
"bruli/php-value-objects": "~0.1",
"bruli/event-bus-bundle": "^0.5",
"symfony/flex": "~1.0"
"symfony/flex": "~1.0",
"symfony/process": "^4.0|^5.0"
},
"require-dev": {
"fzaninotto/faker": "^1.6",
Expand Down
16 changes: 12 additions & 4 deletions src/PhpGitHooks/Module/Configuration/Infrastructure/Hook/HookCopier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,25 +33,33 @@ public function copyPrepareCommitMsgHook(): void

protected function hookExists(string $hookFile): bool
{
return file_exists(sprintf('%s%s', $this->hooksDir, $hookFile));
return \file_exists($this->hooksDir . "/$hookFile");
}

protected function copyFile(string $hookFile): void
{
$copy = new Process(sprintf("mkdir -p {$this->hooksDir} && cp %s %s", $hookFile, $this->hooksDir));
$this->createHooksDir();

$copy = new Process(['cp', $hookFile, $this->hooksDir]);
$copy->run();
}

protected function createHooksDir(): void
{
$mkdir = new Process(['mkdir', '-p', $this->hooksDir]);
$mkdir->run();
}

protected function setPermissions(string $hookFile): void
{
$permissions = new Process(sprintf('chmod 775 %s%s', $this->hooksDir, $hookFile));
$permissions = new Process(['chmod', '775', $this->hooksDir . "/$hookFile"]);
$permissions->run();
}

protected function copyHookFile(string $file): void
{
if (false === $this->hookExists($file)) {
$this->copyFile(sprintf('%s/%s', $this->sourceHooksDir, $file));
$this->copyFile($this->sourceHooksDir . "/$file");
$this->setPermissions($file);
}
}
Expand Down