Skip to content

Fix/consensus/ add node after stall#1016

Merged
Mododo merged 2 commits intomasterfrom
fix/consensus/add-node-after-stall
Feb 13, 2026
Merged

Fix/consensus/ add node after stall#1016
Mododo merged 2 commits intomasterfrom
fix/consensus/add-node-after-stall

Conversation

@Mododo
Copy link
Copy Markdown
Member

@Mododo Mododo commented Jan 30, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

  • rustup update stable for 1.91 msrv

PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

No coverage

Network Tests

No coverage

Manual Tests

using network of 13 nodes
run transfers-30k for the whole test duration
stop 4 nodes (10-13 for example), let them lag for 5 minutes
stop one more node, so consensus stalls as expected
start any of the lagged nodes, wait for it to sync
expect it to join the quorum so consensus advances


Notes/Additional Comments:

@Mododo Mododo requested review from 0xdeafbeef and Rexagon January 30, 2026 23:32
@Mododo Mododo self-assigned this Jan 30, 2026
@Mododo Mododo added the C-consesus Consesus module label Jan 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1016

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1016
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1016 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 41.23711% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.29%. Comparing base (34faef4) to head (e8b0421).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
consensus/src/intercom/broadcast/collector.rs 0.00% 32 Missing ⚠️
consensus/src/engine/committer_task.rs 0.00% 27 Missing ⚠️
consensus/src/dag/commit/mod.rs 51.92% 23 Missing and 2 partials ⚠️
consensus/src/engine/impl_.rs 0.00% 9 Missing ⚠️
consensus/src/models/point_key.rs 44.44% 5 Missing ⚠️
collator/src/mempool/impls/common/cache.rs 0.00% 4 Missing ⚠️
...c/mempool/impls/single_node_impl/anchor_handler.rs 0.00% 3 Missing ⚠️
consensus/src/dag/commit/back.rs 75.00% 2 Missing and 1 partial ⚠️
...lator/src/mempool/impls/std_impl/anchor_handler.rs 0.00% 2 Missing ⚠️
consensus/src/test_utils/anchor_consumer.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   54.35%   54.29%   -0.07%     
==========================================
  Files         403      403              
  Lines       67714    67753      +39     
  Branches    67714    67753      +39     
==========================================
- Hits        36805    36784      -21     
- Misses      29091    29142      +51     
- Partials     1818     1827       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo Mododo added this to the 020 Consensus milestone Jan 31, 2026
@Mododo Mododo force-pushed the fix/consensus/add-node-after-stall branch 2 times, most recently from 4375e06 to 939895f Compare February 3, 2026 20:22
@Mododo Mododo force-pushed the fix/consensus/add-node-after-stall branch 2 times, most recently from b594d7c to 26316b1 Compare February 6, 2026 14:02
* `Collector` watches for pause bound to advance
* `Committer` tracks history reset for `Collator`
* fix history sooner at depth awaited by `Collator`
* propagate cancel from commit to abort in time
* refactor: random digest in tests
@Mododo Mododo force-pushed the fix/consensus/add-node-after-stall branch from 05e302b to e8b0421 Compare February 13, 2026 19:24
@Mododo Mododo added this pull request to the merge queue Feb 13, 2026
Merged via the queue into master with commit 78ac4a1 Feb 13, 2026
21 of 23 checks passed
@Mododo Mododo deleted the fix/consensus/add-node-after-stall branch February 13, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-consesus Consesus module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants