Update publish and invoke to allow for PENDING active state#31
Merged
ajmcquilkin merged 1 commit intomainfrom Feb 10, 2026
Merged
Update publish and invoke to allow for PENDING active state#31ajmcquilkin merged 1 commit intomainfrom
publish and invoke to allow for PENDING active state#31ajmcquilkin merged 1 commit intomainfrom
Conversation
jtoar
approved these changes
Feb 10, 2026
Comment on lines
+124
to
+130
| export function isTerminalBuildStatus(status: BuildStatus): boolean { | ||
| return status !== "PENDING" && status !== "RUNNING"; | ||
| } | ||
|
|
||
| export function isTerminalInvocationStatus(status: InvocationStatus): boolean { | ||
| return status !== "PENDING" && status !== "RUNNING"; | ||
| } |
There was a problem hiding this comment.
Nit: is it easier/better to define these this way (excluding what's not terminal) than the opposite? Feels like we're less likely to add another terminal status than a non-terminal
Collaborator
Author
There was a problem hiding this comment.
Yeah that's fair, although I think I'll punt that to if/when we do that refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
PENDINGstate as an active state in addition toRUNNING. Also cleans up an oldTIMEDOUTstate and replaces it with theFAILEDparent state.Also updates broken docs links.