Skip to content

fix(README.md): 1- zlib URL; 2 - patch version type description. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brimworks merged 1 commit into from
Apr 9, 2025
Merged

fix(README.md): 1- zlib URL; 2 - patch version type description. #74

brimworks merged 1 commit into from
Apr 9, 2025

Conversation

@luau-project
Copy link
Contributor

@luau-project luau-project commented Apr 9, 2025

Description

  1. Fixes zlib URL (the current one is returning a 404 error - NOT FOUND)
  2. Changes the description about the returned type of patch in zlib.version() method: the correct return type is integer or nil, because for zlib 1.3, the returned patch is nil (see Tests fail for zlib 1.3 #70, which was fixed by fix: tests for zlib 1.3 #71)

brimworks
brimworks approved these changes Apr 9, 2025
View reviewed changes
Copy link
Owner

@brimworks brimworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brimworks brimworks merged commit 10f427f into brimworks:master Apr 9, 2025
19 checks passed
@luau-project luau-project deleted the fix-README branch April 9, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brimworks brimworks brimworks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luau-project @brimworks