vam: fix panic in upcast()#7006
Draft
nwt wants to merge 1 commit into
Draft
Conversation
runtime/vam/expr/function.Upcast.deunionAndUpcast does not change the type of zero-length vectors. This causes trouble because the vectors passed to vbuild.MergeSameTypesInDynamic then have multiple types, causing that function to return a vector.Dynamic instead of the expected vector with the target type. Fix by changing the type of zero-length vectors to the target type in deunionAndUpcast and then skipping zero-length vectors in vbuild.Merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime/vam/expr/function.Upcast.deunionAndUpcast does not change the type of zero-length vectors. This causes trouble because the vectors passed to vbuild.MergeSameTypesInDynamic then have multiple types, causing that function to return a vector.Dynamic instead of the expected vector with the target type. Fix by changing the type of zero-length vectors to the target type in deunionAndUpcast and then skipping zero-length vectors in vbuild.Merge.