Skip to content

sam compareValues: Deunion values before compare#6655

Merged
mattnibs merged 1 commit intomainfrom
sam-compare-deunion
Feb 24, 2026
Merged

sam compareValues: Deunion values before compare#6655
mattnibs merged 1 commit intomainfrom
sam-compare-deunion

Conversation

@mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Feb 23, 2026

Fixes #6649

@mattnibs mattnibs requested a review from a team February 23, 2026 22:09
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test, please.

@philrz
Copy link
Contributor

philrz commented Feb 23, 2026

FYI, repeating the repro steps from #6649 on this branch at commit 8da7316, it does appear the fix is effective. 👍

@mattnibs mattnibs force-pushed the sam-compare-deunion branch from d04cf55 to 2d76aac Compare February 23, 2026 22:36
@mattnibs
Copy link
Collaborator Author

mattnibs commented Feb 23, 2026

Test, please.

@nwt this is a fix for #6649 which is intermittently caused by union values causing values to be compared by bytes.Compare. I don't have a reliable way of testing this but am open to suggestions.

EDIT

I came up with a way

@mattnibs mattnibs force-pushed the sam-compare-deunion branch from 2d76aac to 96ede05 Compare February 23, 2026 23:03
@mattnibs mattnibs force-pushed the sam-compare-deunion branch from 96ede05 to aebe414 Compare February 24, 2026 17:16
@mattnibs mattnibs force-pushed the sam-compare-deunion branch from aebe414 to 2ea1791 Compare February 24, 2026 17:27
@mattnibs mattnibs merged commit 8ad0eed into main Feb 24, 2026
2 checks passed
@mattnibs mattnibs deleted the sam-compare-deunion branch February 24, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate buckets in aggregation query against persistent DB storage

3 participants