mdtest: Run tests in both vam and sam runtimes#6648
Merged
Conversation
mattnibs
force-pushed
the
vam-mdtests
branch
from
724f2ac to
64c1a00
Compare
nwt
reviewed
Feb 23, 2026
nwt
reviewed
Feb 23, 2026
nwt
reviewed
Feb 23, 2026
mattnibs
force-pushed
the
vam-mdtests
branch
2 times, most recently
from
2d4227c to
eacead9
Compare
nwt
approved these changes
Feb 24, 2026
mdtest/mdtest.go
Outdated
Comment on lines
245
to
247
| default: | ||
| msg := fmt.Sprintf("unknown word in mdtest-spq info string: %q", word) | ||
| return ast.WalkStop, fcbError(fcb, source, msg) |
Member
There was a problem hiding this comment.
This isn't compatible with the {...} layout hints we use and we've been fine so far without it so maybe just leave it out?
Collaborator
Author
There was a problem hiding this comment.
I don't like having the value not checked because if not you could end up running no tests. I'll add back what I had here.
mattnibs
force-pushed
the
vam-mdtests
branch
from
eacead9 to
123d780
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.