Skip to content

Fix Windows CI: update swift-docc-plugin to 1.4.6#131

Merged
leogdion merged 1 commit into128-workflow-updatesfrom
fix/windows-docc-plugin-symlinks
Apr 2, 2026
Merged

Fix Windows CI: update swift-docc-plugin to 1.4.6#131
leogdion merged 1 commit into128-workflow-updatesfrom
fix/windows-docc-plugin-symlinks

Conversation

@leogdion
Copy link
Copy Markdown
Member

@leogdion leogdion commented Apr 2, 2026

Summary

  • Updates swift-docc-plugin from 1.4.51.4.6 in Package.resolved

Problem

Windows CI (windows-2022 and windows-2025) was failing with:

error: cannot find 'Lock' in scope
error: cannot find type 'SnippetExtractor' in scope
error: cannot find type 'ParsedSymbolGraphArguments' in scope

The root cause: swift-docc-plugin uses a Symbolic Links/ directory to share source files across plugin targets. On Windows, without proper .gitattributes, git checks these symlinks out as plain text files (containing just the path string). The Swift compiler then tries to compile these empty stubs, producing missing-type errors.

Fix

swift-docc-plugin 1.4.6 release notes: "Add .gitattributes for symlinks on Windows." — this ensures git resolves symlinks to real source files on Windows checkouts.

Package.swift already declares from: "1.4.0", so only Package.resolved needed updating.

Test plan

  • Build on Windows (windows-2022) passes
  • Build on Windows (windows-2025) passes

🤖 Generated with Claude Code


Perform an AI-assisted review on CodePeer.com

1.4.6 adds .gitattributes for symlinks on Windows, fixing build failures
where symlinked plugin source files were checked out as plain text, causing
'cannot find Lock in scope' and related errors.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2369fdaf-0618-4375-922a-fff6a0a669d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-docc-plugin-symlinks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown

claude bot commented Apr 2, 2026

Code Review: Fix Windows CI - update swift-docc-plugin to 1.4.6

The Package.resolved update is the right fix — swift-docc-plugin 1.4.6 adds .gitattributes for symlink handling on Windows, which directly addresses the missing-type errors from symlinks being checked out as text files.

Duplicate PR notice

This PR (131) and PR 132 are both from the same branch 'fix/windows-docc-plugin-symlinks' but target different bases:

  • PR 131 targets '128-workflow-updates'
  • PR 132 targets 'v0.0.4'

One of them should be closed to avoid confusion. If the workflow optimizations from 128-workflow-updates are meant to land first, PR 131 (on top of that branch) is the right one to keep. If this fix needs to go into the release branch independently, PR 132 is correct — but then PR 131 becomes redundant once 129 merges.

The fix itself

Minimal and correct. Package.swift already declares 'from: "1.4.0"' so only Package.resolved needed updating. No source changes required.

@leogdion leogdion merged commit a77fb0f into 128-workflow-updates Apr 2, 2026
43 of 53 checks passed
@leogdion leogdion deleted the fix/windows-docc-plugin-symlinks branch April 2, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant