Fix Windows CI: update swift-docc-plugin to 1.4.6#131
Fix Windows CI: update swift-docc-plugin to 1.4.6#131leogdion merged 1 commit into128-workflow-updatesfrom
Conversation
1.4.6 adds .gitattributes for symlinks on Windows, fixing build failures where symlinked plugin source files were checked out as plain text, causing 'cannot find Lock in scope' and related errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review: Fix Windows CI - update swift-docc-plugin to 1.4.6The Package.resolved update is the right fix — swift-docc-plugin 1.4.6 adds .gitattributes for symlink handling on Windows, which directly addresses the missing-type errors from symlinks being checked out as text files. Duplicate PR notice This PR (131) and PR 132 are both from the same branch 'fix/windows-docc-plugin-symlinks' but target different bases:
One of them should be closed to avoid confusion. If the workflow optimizations from 128-workflow-updates are meant to land first, PR 131 (on top of that branch) is the right one to keep. If this fix needs to go into the release branch independently, PR 132 is correct — but then PR 131 becomes redundant once 129 merges. The fix itself Minimal and correct. Package.swift already declares 'from: "1.4.0"' so only Package.resolved needed updating. No source changes required. |
Summary
swift-docc-pluginfrom1.4.5→1.4.6inPackage.resolvedProblem
Windows CI (
windows-2022andwindows-2025) was failing with:The root cause:
swift-docc-pluginuses aSymbolic Links/directory to share source files across plugin targets. On Windows, without proper.gitattributes, git checks these symlinks out as plain text files (containing just the path string). The Swift compiler then tries to compile these empty stubs, producing missing-type errors.Fix
swift-docc-plugin1.4.6 release notes: "Add .gitattributes for symlinks on Windows." — this ensures git resolves symlinks to real source files on Windows checkouts.Package.swiftalready declaresfrom: "1.4.0", so onlyPackage.resolvedneeded updating.Test plan
Build on Windows (windows-2022)passesBuild on Windows (windows-2025)passes🤖 Generated with Claude Code
Perform an AI-assisted review on