Skip to content

fix instance type id creation on nebius #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerfong merged 3 commits into from
Dec 9, 2025
Merged

fix instance type id creation on nebius #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24fbb6f
fix instance type id
theFong Dec 9, 2025
ccaac59
use proper constructor and improve tests
theFong Dec 9, 2025
fbe701a
ignore lint
theFong Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/validation/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,17 @@ func RunInstanceLifecycleValidation(t *testing.T, config ProviderConfig) {

t.Run("ValidateCreateInstance", func(t *testing.T) {
attrs := v1.CreateInstanceAttrs{}
selectedType := v1.InstanceType{}
for _, typ := range types {
if typ.IsAvailable {
attrs.InstanceType = typ.Type
attrs.Location = typ.Location
attrs.PublicKey = ssh.GetTestPublicKey()
selectedType = typ
break
}
}
instance, err := v1.ValidateCreateInstance(ctx, client, attrs)
instance, err := v1.ValidateCreateInstance(ctx, client, attrs, selectedType)
if err != nil {
t.Fatalf("ValidateCreateInstance failed: %v", err)
}
Expand Down
5 changes: 4 additions & 1 deletion v1/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type CloudCreateTerminateInstance interface {
CloudInstanceReader
}

func ValidateCreateInstance(ctx context.Context, client CloudCreateTerminateInstance, attrs CreateInstanceAttrs) (*Instance, error) {
func ValidateCreateInstance(ctx context.Context, client CloudCreateTerminateInstance, attrs CreateInstanceAttrs, selectedType InstanceType) (*Instance, error) { //nolint:gocyclo // ok
t0 := time.Now().Add(-time.Minute)
attrs.RefID = uuid.New().String()
name, err := makeDebuggableName(attrs.Name)
Expand Down Expand Up @@ -67,6 +67,9 @@ func ValidateCreateInstance(ctx context.Context, client CloudCreateTerminateInst
if attrs.InstanceType != "" && attrs.InstanceType != i.InstanceType {
validationErr = errors.Join(validationErr, fmt.Errorf("instanceType mismatch: %s != %s", attrs.InstanceType, i.InstanceType))
}
if selectedType.ID != "" && selectedType.ID != i.InstanceTypeID {
validationErr = errors.Join(validationErr, fmt.Errorf("instanceTypeID mismatch: %s != %s", selectedType.ID, i.InstanceTypeID))
}

return i, validationErr
}
Expand Down
9 changes: 5 additions & 4 deletions v1/providers/nebius/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,15 +334,14 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance *
sshUser = "admin"
}

return &v1.Instance{
inst := &v1.Instance{
RefID: refID,
CloudCredRefID: c.refID,
Name: instance.Metadata.Name,
CloudID: instanceID,
Location: location,
CreatedAt: createdAt,
InstanceType: instanceTypeID, // Full instance type ID (e.g., "gpu-h100-sxm.8gpu-128vcpu-1600gb")
InstanceTypeID: v1.InstanceTypeID(instanceTypeID), // Same as InstanceType - required for dev-plane lookup
InstanceType: instanceTypeID, // Full instance type ID (e.g., "gpu-h100-sxm.8gpu-128vcpu-1600gb")
ImageID: imageFamily,
DiskSize: units.Base2Bytes(diskSize),
DiskSizeBytes: v1.NewBytes(v1.BytesValue(diskSize), v1.Byte), // diskSize is already in bytes from getBootDiskSize
Expand All @@ -355,7 +354,9 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance *
Hostname: hostname,
SSHUser: sshUser,
SSHPort: 22, // Standard SSH port
}, nil
}
inst.InstanceTypeID = v1.MakeGenericInstanceTypeIDFromInstance(*inst)
return inst, nil
}

// waitForInstanceRunning polls the instance until it reaches RUNNING state or fails
Expand Down
Loading