Skip to content

fix: handle provider status default cases across providers. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garvitssoni wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: handle provider status default cases across providers. #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
283b69b
fix: handle provider status default cases across providers
garvitssoni Apr 7, 2026
37f6b33
fix: handle provider status default cases across providers
garvitssoni Apr 7, 2026
c0ff74d
fix: handle provider status default cases across providers
garvitssoni Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions v1/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ const (
LifecycleStatusTerminating LifecycleStatus = "terminating"
LifecycleStatusTerminated LifecycleStatus = "terminated"
LifecycleStatusFailed LifecycleStatus = "failed"
LifecycleStatusEmpty LifecycleStatus = ""
)

const (
Expand Down
2 changes: 1 addition & 1 deletion v1/providers/fluidstack/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func convertFluidStackInstanceToV1Instance(fsInstance openapi.Instance) *v1.Inst
case openapi.INSTANCE_ERROR:
lifecycleStatus = v1.LifecycleStatusFailed
default:
lifecycleStatus = v1.LifecycleStatusPending
lifecycleStatus = ""
}

instance := &v1.Instance{
Expand Down
2 changes: 1 addition & 1 deletion v1/providers/lambdalabs/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func convertLambdaLabsStatusToV1Status(status string) v1.LifecycleStatus {
case "unhealthy":
return v1.LifecycleStatusRunning
default:
return v1.LifecycleStatusPending
return v1.LifecycleStatusEmpty
}
}

Expand Down
2 changes: 1 addition & 1 deletion v1/providers/nebius/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ func (c *NebiusClient) convertNebiusInstanceToV1(ctx context.Context, instance *
case compute.InstanceStatus_ERROR:
lifecycleStatus = v1.LifecycleStatusFailed
default:
lifecycleStatus = v1.LifecycleStatusFailed
lifecycleStatus = v1.LifecycleStatusEmpty
}
} else {
lifecycleStatus = v1.LifecycleStatusFailed
Expand Down
2 changes: 1 addition & 1 deletion v1/providers/sfcompute/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func sfcStatusToLifecycleStatus(status string) v1.LifecycleStatus {
case "nodefailure", "failed":
return v1.LifecycleStatusFailed
default:
return v1.LifecycleStatusPending
return v1.LifecycleStatusEmpty
}
}

Expand Down
2 changes: 1 addition & 1 deletion v1/providers/shadeform/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ func (c *ShadeformClient) getLifecycleStatus(status string) v1.LifecycleStatus {
case "error":
lifecycleStatus = v1.LifecycleStatusFailed
default:
lifecycleStatus = v1.LifecycleStatusPending
lifecycleStatus = v1.LifecycleStatusEmpty
}
return lifecycleStatus
}
Expand Down
Loading