fix: remove brev reset suggestion from brev ls output#402
Closed
arush070 wants to merge 1 commit into
Closed
Conversation
arush070
force-pushed
the
brev-9452/brev-reset-error-fix
branch
from
934ba3b to
2f71d47
Compare
Contributor
Author
|
Closing in favor of clean branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
Reset unhealthy or failed instance: brev reset <name>suggestion shown inbrev lsoutput for unhealthy/failed instances.brev resetis only implemented for AWS in the backend for every other provider (GCP, Crusoe, Nebius, Shadeform, SFCompute, Launchpad) it returns "not implemented". Surfacing this suggestion to users on those providers was misleading and led them to a command that would fail.Linear: BREV-9452
Changes
displayLsResetBreadCrumbfunction (now dead code)ShowOrgWorkspacesanddisplayWorkspacesAndHelp